Add regression test for IVM resetting the encoding context#1022
Open
popematt wants to merge 1 commit into
Open
Add regression test for IVM resetting the encoding context#1022popematt wants to merge 1 commit into
popematt wants to merge 1 commit into
Conversation
popematt
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1022 +/- ##
==========================================
+ Coverage 78.97% 79.00% +0.02%
==========================================
Files 140 140
Lines 34822 34843 +21
Branches 34822 34843 +21
==========================================
+ Hits 27502 27526 +24
+ Misses 5245 5238 -7
- Partials 2075 2079 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fix #1020
Description of changes:
When investigating #1020, I discovered that it was already fixed by #940 (but that change had not yet been released). That PR added test cases for the conformance test runner, but the issue also existed (and was also fixed) for non-conformance-test use cases. Before closing #1020, I want to add the reproduction from the issue so that if we ever update/replace the conformance tests, we don't lose the test coverage for this case.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.